Implement tri-state disabled field for TLS configuration #1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change TLS disabled field from bool to Option<bool> to support three states: - None: TLS behavior depends on other factors (API key, etc.) - Some(false): TLS explicitly enabled - Some(true): TLS explicitly disabled This fixes TOML serialization asymmetry where "not set" vs "explicitly false" could not be distinguished, ensuring proper round-trip compatibility.
cretz
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Change TLS disabled field from bool to Option to support three states:
This fixes TOML serialization asymmetry where "not set" vs "explicitly false" could not be distinguished, ensuring proper round-trip compatibility.
How was this tested:
Existing test suite passes, added test for tri-state
disabledfield.Any docs updates needed?
No