Skip to content

Implement Test Operator Service #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2022
Merged

Implement Test Operator Service #1071

merged 1 commit into from
Mar 14, 2022

Conversation

Spikhalskiy
Copy link
Contributor

@Spikhalskiy Spikhalskiy commented Mar 14, 2022 •
edited
Loading

What was changed

Implemented Test Operator Service
Refactored Test Server to support pluggable services
Created new public Test Server API

Issue #617

@Spikhalskiy Spikhalskiy added this to the 1.9.0 milestone Mar 14, 2022
mmcshane
mmcshane reviewed Mar 14, 2022
View reviewed changes
Copy link
Contributor

@mmcshane mmcshane left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on locking may or may not be needed - I'm not 100% on the expected usage

Confused though as to why we're not sending sleep to the out-of-proc server?

@Spikhalskiy
Copy link
Contributor Author

@mmcshane
What can be an out-of-process test server?
Dockerized Service. Doesn't support time skipping.
Test Service. Doesn't expose time skipping API right now. And who will be using the out of process test server with java if there is a java version? :)

@Spikhalskiy
Implement Test Operator Service
11e320d 
Refactor Test Server to support pluggable services
@Spikhalskiy Spikhalskiy merged commit db949e7 into temporalio:master Mar 14, 2022
@Spikhalskiy Spikhalskiy deleted the issue-617-2 branch April 15, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfateev mfateev Awaiting requested review from mfateev

@Sushisource Sushisource Awaiting requested review from Sushisource

@cretz cretz Awaiting requested review from cretz

@bergundy bergundy Awaiting requested review from bergundy

1 more reviewer

@mmcshane mmcshane mmcshane approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Spikhalskiy @mmcshane