Skip to content

Conversation

nagl-stripe
Copy link
Contributor

What was changed

This makes the implementation of DescribeWorkflowExecution in the test service aware of calls to Workflow.upsertSearchAttributes.

Why?

The test service's describe method had a bug that impacted any workflow that upserted search attributes.

Checklist

  1. Closes (nothing)

  2. How was this tested:

cd temporal-sdk
# using TestWorkflowService
USE_DOCKER_SERVICE=false ../gradlew test --tests io.temporal.workflow.DescribeTest
# using docker-compose to make sure we match the real service's behavior
USE_DOCKER_SERVICE=true ../gradlew test --tests io.temporal.workflow.DescribeTest
  1. Any docs updates needed?
    None.

@Spikhalskiy
Copy link
Contributor

Thank you for the contribution, great job!

@Spikhalskiy Spikhalskiy merged commit 6ddde0b into temporalio:master Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants