Sprint Boot TestWorkflowEnvironment now respects configured MetricsRegistry, Tracer, DataConverter #1622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spikhalskiy
requested review from
Sushisource,
bergundy,
cretz,
mfateev and
mmcshane
as code owners
Spikhalskiy
force-pushed
the
issue-1463
branch
4 times, most recently
from
a924470 to
bc80694
Compare
…gistry, Tracer, DataConverter Issue temporalio#1463
Spikhalskiy
force-pushed
the
issue-1463
branch
from
bc80694 to
61556ed
Compare
cretz
approved these changes
Jan 26, 2023
Comment on lines
+36
to
+38
| @AutoConfigureAfter( | ||
| name = | ||
| "org.springframework.boot.actuate.autoconfigure.metrics.CompositeMeterRegistryAutoConfiguration") |
There was a problem hiding this comment.
Suggested change
| @AutoConfigureAfter( | |
| name = | |
| "org.springframework.boot.actuate.autoconfigure.metrics.CompositeMeterRegistryAutoConfiguration") | |
| @AutoConfigureAfter(CompositeMeterRegistryAutoConfiguration.class) |
Or do we not want to import and static init that class here?
There was a problem hiding this comment.
We don't know if the class will be even present in the classpath here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Sprint Boot TestWorkflowEnvironment now respects configured MetricsRegistry, Tracer, DataConverter
Why
Closes #1463