Make StickyQueueBalancer synchronized #2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make StickyQueueBalancer synchronized to avoid potential race where all initial calls to `makePoll()` all get assigned the same task queue.
Sushisource
approved these changes
Apr 8, 2024
cretz
approved these changes
Apr 8, 2024
| * @return task queue kind that should be used for the next poll | ||
| */ | ||
| public TaskQueueKind makePoll() { | ||
| public synchronized TaskQueueKind makePoll() { |
There was a problem hiding this comment.
Usually linters will tell you not to add this keyword but instead make a private final object that you wrap in synchronized (theObject) { because it can be unclear to users of this class that they can cause deadlocks if they try to also synchronize on this instance. Probably fine in internal code though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make StickyQueueBalancer synchronized to avoid potential race where all initial calls to
makePoll()all get assigned the same task queue.