Send original update request back in accept/reject response #2074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
May 21, 2024
| .build(); | ||
|
|
||
| // Clear the original request to allow GC to reclaim the memory. | ||
| originalRequest = Optional.empty(); |
There was a problem hiding this comment.
Should do this on reject too correct? Or is there no reason because reject removes this whole state machine?
There was a problem hiding this comment.
reject is a terminal state so the whole state machine will be cleaned up
Sushisource
approved these changes
May 21, 2024
Quinn-With-Two-Ns
force-pushed
the
issue-2073
branch
from
2f2ffba to
e1a91ab
Compare
Quinn-With-Two-Ns
force-pushed
the
issue-2073
branch
from
e1a91ab to
ec5c5d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send original update request back in accept/reject response
close #2073