Avoid activity task prefetching when handlers are busy #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfateev
reviewed
Dec 22, 2020
temporal-sdk/src/main/java/io/temporal/internal/worker/ActivityTask.java
Outdated
Show resolved
Hide resolved
Sushisource
reviewed
Dec 22, 2020
temporal-sdk/src/main/java/io/temporal/internal/worker/ActivityTask.java
Show resolved
Hide resolved
temporal-sdk/src/main/java/io/temporal/testing/TestEnvironmentOptions.java
Show resolved
Hide resolved
temporal-sdk/src/test/java/io/temporal/workflow/WorkerRule.java
Outdated
Show resolved
Hide resolved
mfateev
reviewed
Dec 22, 2020
temporal-sdk/src/main/java/io/temporal/testing/TestEnvironmentOptions.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/test/java/io/temporal/workflow/ActivityPollerPrefetchingTest.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/test/java/io/temporal/workflow/WorkerRule.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/test/java/io/temporal/workflow/WorkerRule.java
Outdated
Show resolved
Hide resolved
mfateev
reviewed
Dec 22, 2020
temporal-sdk/src/test/java/io/temporal/workflow/WorkerRule.java
Outdated
Show resolved
Hide resolved
Sushisource
approved these changes
Dec 22, 2020
mfateev
reviewed
Dec 22, 2020
temporal-sdk/src/main/java/io/temporal/testing/TestEnvironmentOptions.java
Show resolved
Hide resolved
mfateev
reviewed
Dec 22, 2020
temporal-sdk/src/main/java/io/temporal/testing/TestEnvironmentOptions.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/main/java/io/temporal/internal/worker/ActivityWorker.java
Outdated
Show resolved
Hide resolved
mfateev
reviewed
Dec 22, 2020
temporal-sdk/src/main/java/io/temporal/internal/worker/ActivityPollTask.java
Show resolved
Hide resolved
mfateev
approved these changes
Dec 22, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, This PR is heavily based on #278 proposal by Maxim, which superseded initial implementation in #277.
On top of that I've addressed an issue with late semaphore acquisition and added a test that verifies that poller behavior is correct and tasks are not getting pre-fetched when handlers are busy.
As a bonus I've created a WorkerRule, which takes care of the common boilerplate used in tests to create workflow workers and can be used to write tests easily without needing to expand already gigantic WorkflowTest.
Closes #256