Refactor WorkflowTest #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkoby
force-pushed
the
refactor-workflowtest
branch
from
17eadfd to
4d3c90c
Compare
vkoby
force-pushed
the
refactor-workflowtest
branch
from
a7c9827 to
714251c
Compare
…n Docker was used. When using the rule, testEnvironment is never null, so it failed in Docker. Inserted if statement to skip this test in Docker.
mfateev
reviewed
Mar 30, 2021
temporal-sdk/src/test/java/io/temporal/workflow/BinaryChecksumSetWhenTaskCompletedTest.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/test/java/io/temporal/workflow/BinaryChecksumSetWhenTaskCompletedTest.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/test/java/io/temporal/workflow/BinaryChecksumSetWhenTaskCompletedTest.java
Outdated
Show resolved
Hide resolved
mfateev
reviewed
Mar 31, 2021
temporal-testing-junit4/src/main/java/io/temporal/testing/TestWorkflowRule.java
Outdated
Show resolved
Hide resolved
mfateev
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of WorkflowTest Refactor task: This test file was 7k lines long and contained dozens of tests.
In addition to readability breaking it up will also enable Gradle to run all those tests in parallel.