Fix a potential NullPointer in exception processing inside WorkflowStubImpl #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spikhalskiy
requested review from
Sushisource,
mfateev and
vitarb
as code owners
Spikhalskiy
force-pushed
the
workflow-stub-start-exception-fix
branch
2 times, most recently
from
07c7185 to
8ace12c
Compare
mfateev
reviewed
Apr 6, 2021
temporal-sdk/src/main/java/io/temporal/internal/sync/WorkflowStubImpl.java
Show resolved
Hide resolved
Spikhalskiy
force-pushed
the
workflow-stub-start-exception-fix
branch
2 times, most recently
from
08b796e to
d9835af
Compare
mfateev
approved these changes
Apr 6, 2021
...al-sdk/src/test/java/io/temporal/workflow/interceptorsTests/InterceptorsExceptionsTests.java
Outdated
Show resolved
Hide resolved
…ubImpl Address the problem with WorkflowStubImpl#startWithOptions and WorkflowStubImpl#signalWithStartWithOptions passing workflowExecution that could be not initialized into NotNull workflowExecution param of WorkflowServiceException constructor
Spikhalskiy
force-pushed
the
workflow-stub-start-exception-fix
branch
from
d9835af to
1383ca9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed:
Address the problem with
WorkflowStubImpl#startWithOptionsandWorkflowStubImpl#signalWithStartWithOptionspassingworkflowExecutionthat could be not initialized into NotNullworkflowExecutionparam ofWorkflowServiceExceptionconstructorWhy?
Preserves an original exception from an Interceptor if it happens instead of replacing it with a meaningless NullPointer.