Per Activity Method Options (Part I) #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
March 16, 2021 14:39
Map<String, ActivityOptions> activityMethodOptions Workflow.newActivityStub(AccountActivity.class, options, activityMethodOptions)
mfateev
reviewed
Apr 8, 2021
temporal-sdk/src/main/java/io/temporal/activity/ActivityOptions.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/main/java/io/temporal/activity/ActivityOptions.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/main/java/io/temporal/activity/ActivityOptions.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/main/java/io/temporal/internal/sync/ActivityInvocationHandler.java
Show resolved
Hide resolved
temporal-sdk/src/main/java/io/temporal/internal/sync/ActivityInvocationHandler.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/main/java/io/temporal/internal/sync/ActivityInvocationHandler.java
Show resolved
Hide resolved
temporal-sdk/src/main/java/io/temporal/internal/sync/ActivityInvocationHandler.java
Outdated
Show resolved
Hide resolved
mfateev
reviewed
Apr 8, 2021
…of the options to the constructor. Added ability to set taskQueue through method options
vkoby
changed the title
mfateev
reviewed
Apr 9, 2021
temporal-sdk/src/main/java/io/temporal/internal/sync/ActivityInvocationHandler.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/main/java/io/temporal/worker/WorkflowImplementationOptions.java
Outdated
Show resolved
Hide resolved
mfateev
reviewed
Apr 14, 2021
temporal-sdk/src/test/java/io/temporal/activity/ActivityMethodOptionsTest.java
Outdated
Show resolved
Hide resolved
Added method options test for Local Activities.
mfateev
reviewed
Apr 15, 2021
temporal-sdk/src/main/java/io/temporal/activity/LocalActivityOptions.java
Outdated
Show resolved
Hide resolved
mfateev
approved these changes
Apr 15, 2021
temporal-testing/src/main/java/io/temporal/testing/TestActivityEnvironment.java
Outdated
Show resolved
Hide resolved
temporal-testing/src/main/java/io/temporal/testing/TestActivityEnvironment.java
Outdated
Show resolved
Hide resolved
added 2 commits
April 15, 2021 17:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to pass activity method options to activityStub. Usage:
Map<activityTypeName, ActivityOptions> activityMethodOptions
Map<activityTypeName, LocalActivityOptions> localActivityMethodOptions
Workflow.newActivityStub(Activity.class, options, activityMethodOptions)
Workflow.newLocalActivityStub(Activity.class, options, localActivityMethodOptions)
WIP: Ability to pass activity method options with WorkflowImplementationOptions.
Fix for issue #370