Do not override Micrometer's naming conventions #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MeterRegistry passed to the MicrometerClientStatsReporter might have some naming convention already set, and creation of MicrometerClientStatsReporter would override it.
GreyTeardrop
requested review from
Sushisource,
mfateev and
vitarb
as code owners
mfateev
approved these changes
Apr 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed:
MicrometerClientStatsReporterno longer setsnamingConventionon theMeterRegistrypassed to it.Why?
The
MeterRegistrypassed to theMicrometerClientStatsReportermight have some naming convention already set, and the creation ofMicrometerClientStatsReporterwould override it.Also, the
snakeCaseconvention is the default one for anyMeterRegistry, so an explicit set would only be required if specific registry sets some other convention, in which case it might make sense to keep it as it.Checklist
MicrometerClientStatsReporter.