Local type #441
Merged
Local type #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitarb
reviewed
Apr 13, 2021
| private final Duration localRetryThreshold; | ||
| private final Duration startToCloseTimeout; | ||
| private final RetryOptions retryOptions; | ||
| private boolean doNotIncludeArgumentsIntoMarker; |
There was a problem hiding this comment.
nit. generally positive naming is preferable when possible, can we call it includeArgumentsIntoMarker instead and flip the logic, this way we can avoid code like !localActivityParameters.isDoNotIncludeArgumentsIntoMarker() which is not very readable cause it's a "not do not".
There was a problem hiding this comment.
I always follow the pattern that all properties defaults should match the type default. For a boolean the default value is false. That's why I named the property this way to make the false default value correct.
vitarb
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed:
Changes to the MarkerRecordedEvent details map.
LocalActivityOptions.doNotIncludeArgumentsIntoMarkerto reduce history size.Also did refactoring of unit tests to reduce repetitive code.
Why?
Debugging local activities is hard as their type and arguments are not part of the event history.
Checklist
Closes issue:
Fix for Include local activity input into its marker decision #135.
How was this tested:
Looking for the "input" field in the UI.