Health Check #504
Merged
Health Check #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitarb
suggested changes
May 27, 2021
There was a problem hiding this comment.
Please consider what we have in go, also look at temporalio/sdk-go#453 where we've added retries for health check.
We need to have same/similar naming and configuration defaults across go and java.
vitarb
reviewed
May 28, 2021
temporal-serviceclient/src/main/java/io/temporal/serviceclient/WorkflowServiceStubsImpl.java
Show resolved
Hide resolved
vitarb
reviewed
May 28, 2021
| * HealthCheckAttemptTimeout specifies how to long to wait for service response on each health | ||
| * check attempt. Default: 5s. | ||
| */ | ||
| private final Duration HealthCheckAttemptTimeout; |
There was a problem hiding this comment.
s/HealthCheckAttemptTimeout/healthCheckAttemptTimeout
vitarb
approved these changes
May 28, 2021
robzienert
pushed a commit
to robzienert/sdk-java
that referenced
this pull request
Jul 23, 2021
…LLEY/nflx-temporal-sdk:merge_oss to master * commit '671858b5039cbce290427ddcf723149c6e60cdd1': Small tweak to upgrade notes Document upgrade Comment out changes that pull in dependencies from grpc 1.34+ Add netflix.io.grpc:grpc-services-nflx update dependency locks Implement configurable DEFAULT_DEADLOCK_DETECTION_TIMEOUT (temporalio#524) Change InterruptedException logs to debug-level. (temporalio#533) Updated dependencies. (temporalio#532) Fixed flaky DetachedScopeTest + Javadoc + Refactoring (temporalio#526) Add getWorker method to TestWorkflowRule (temporalio#528) Avoid throwing IllegalStateException in NoopSuspendableWorker (temporalio#527) Cleaning up Activity Javadocs (temporalio#453) Add workerFactoryOptions override to the JUnit 5 extension (temporalio#520) Removes slf4j-simple from api scope (temporalio#523) Release v1.0.9 (temporalio#522) Fix health check attributes (temporalio#519) Release v1.0.8 (temporalio#518) Out-of-process test server (temporalio#470) Health Check (temporalio#504) Workflow retry in Test Service (temporalio#510)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added optional health check that's performed by the client by making a request to endpoint to make sure that the server is accessible.
Unit test