Expose a fixed implementation of WorkflowQueue as a new method of Workflow class #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spikhalskiy
force-pushed
the
569-backwards-compatibility-fix
branch
from
1899929 to
f075967
Compare
…kflow class Follow-up to temporalio#569 to preserve backwards compatibility with existing workflows.
Spikhalskiy
force-pushed
the
569-backwards-compatibility-fix
branch
from
f075967 to
b23fce6
Compare
mfateev
approved these changes
Jul 5, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #569 to preserve backward compatibility with existing workflows.
What was changed
New fixed implementation of
WorkflowQueueis exposed in a newWorkflow.newWorkflowQueuemethod preserving the behavior of the oldWorkflow.newQueueimplementation, which is marked as deprecated now.Why?
#569 fixes implementations of some methods of WorkflowQueueImpl but does it in a backward-incompatible way with existing workflows that could be not replayable after that.