Polish JUnit5 extension: per-test initial time, dynamic workflows and activities #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GreyTeardrop
requested review from
Spikhalskiy,
Sushisource,
mfateev and
vitarb
as code owners
Override per-test initial workflow time via the @WorkflowInitialTime annotation.
GreyTeardrop
force-pushed
the
junit5-initial-time-override
branch
from
539e89b to
174692f
Compare
Extend TestActivityExtension and TestWorkflowExtension to support dynamic activity and workflow implementations. If a dynamic implementation is registered with the extension, it would support injecting any typed stub into a test.
GreyTeardrop
force-pushed
the
junit5-initial-time-override
branch
from
31ada12 to
a198283
Compare
GreyTeardrop
changed the title
Spikhalskiy
approved these changes
Jul 27, 2021
Spikhalskiy
reviewed
Jul 27, 2021
temporal-testing-junit5/src/main/java/io/temporal/testing/TestActivityExtension.java
Show resolved
Hide resolved
Spikhalskiy
reviewed
Jul 27, 2021
temporal-testing-junit5/src/main/java/io/temporal/testing/TestWorkflowExtension.java
Show resolved
Hide resolved
Only inject proper workflow/activity interfaces.
|
Thank you for your contribution! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
TestWorkflowExtensionis changed to support per-test overrides for the virtual time used by theTestWorkflowEnvironment.WorkflowOptionsis stored in the extension context instead of just the task queue name, to reduce some code duplication.TestWorkflowExtensionandTestActivityExtensionto support dynamic workflow/activity scenarios.Why?
One of our workflows has time-sensitive logic and we'd like to test it in multiple scenarios that differ in the initial workflow time. Right now we either have to fall back to manually managing
TestWorkflowEnvironmentor to split those scenarios into multiple test classes.Checklist