-
Notifications
You must be signed in to change notification settings - Fork 177
Add getMemo to Workflow #611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Memo is exposed to the user as setMemo(Map<String, Object> memo)
(
public Builder setMemo(Map<String, Object> memo) { |
So, getMemo
should return the same deserialized structure, not a raw Protobuf entity.
temporal-sdk/src/main/java/io/temporal/internal/replay/WorkflowContext.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/main/java/io/temporal/internal/sync/WorkflowInternal.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/main/java/io/temporal/internal/replay/ReplayWorkflowContext.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with minor comments, but please address them before merging.
What was changed
Added a getter for Memo in Workflow
Checklist
Closes Missing getMemo functionality in WorkflowInfo #512
How was this tested:
Unit Test