Skip to content

Conversation

vkoby
Copy link
Contributor

@vkoby vkoby commented Jul 29, 2021

What was changed

Added a getter for Memo in Workflow

Checklist

  1. Closes Missing getMemo functionality in WorkflowInfo #512

  2. How was this tested:
    Unit Test

Copy link
Contributor

@Spikhalskiy Spikhalskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Memo is exposed to the user as setMemo(Map<String, Object> memo) (

public Builder setMemo(Map<String, Object> memo) {
)

So, getMemo should return the same deserialized structure, not a raw Protobuf entity.

@vkoby vkoby assigned vkoby and unassigned vkoby Aug 3, 2021
@vkoby vkoby changed the title Added getMemo to WorkflowInfo Add getMemo to Workflow Aug 18, 2021
@vkoby vkoby marked this pull request as draft August 18, 2021 21:55
@vkoby vkoby marked this pull request as ready for review August 19, 2021 19:23
@vkoby vkoby requested a review from Spikhalskiy August 19, 2021 21:25
@vkoby vkoby requested a review from vitarb August 20, 2021 05:21
Copy link
Contributor

@Spikhalskiy Spikhalskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with minor comments, but please address them before merging.

@vkoby vkoby merged commit b034a0f into temporalio:master Aug 26, 2021
@vkoby vkoby deleted the memo branch August 26, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing getMemo functionality in WorkflowInfo

3 participants