Fix misc thread safety issues with WorkflowThreadContext #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spikhalskiy
requested review from
Sushisource,
mfateev and
vitarb
as code owners
Sushisource
approved these changes
Aug 17, 2021
temporal-sdk/src/main/java/io/temporal/internal/sync/WorkflowThreadContext.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/main/java/io/temporal/internal/sync/WorkflowThreadContext.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/main/java/io/temporal/internal/sync/WorkflowThreadContext.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Fixed unsafe publishing and access to
WorkflowThreadImpl#threadby refactoring it out and usingWorkflowThreadContext#currentThreadWorkflowThreadContext#currentThreadis published and exposed in a thread-safe wayDeadlock detection code checks the thread status after waking up to ensure that it's in a correct state and the state didn't change between the wait timeout and acquiring the lock back.