WorkflowExecutionUtils refactoring #717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spikhalskiy
requested review from
Sushisource,
mfateev and
vitarb
as code owners
Spikhalskiy
force-pushed
the
workflowwxecutionutils-refactoring
branch
3 times, most recently
from
95defe9 to
5ad2e42
Compare
WorkflowExecutionUtils is split into WorkflowExecutionUtils, WorkflowClientHelper, WorkflowClientLongPollAsyncHelper, WorkflowClientLongPollHelper to encapsulate independent pieces and simplify further testing and maintenance
Spikhalskiy
force-pushed
the
workflowwxecutionutils-refactoring
branch
from
5ad2e42 to
39fa88f
Compare
Sushisource
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
WorkflowExecutionUtilsis split intoWorkflowExecutionUtils,WorkflowClientHelper,WorkflowClientLongPollAsyncHelper,WorkflowClientLongPollHelper.Why?
WorkflowExecutionUtilsis a large class without a single specific function.WorkflowExecutionUtilsis split toWorkflowExecutionUtils- utility methods helping with all kinds of statuses, internal structures, etc. Intended to be a collection of small static utility methods.WorkflowClientLongPollAsyncHelperandWorkflowClientLongPollHelper- Async and Sync implementations of Long Poll to hide inherent complexity of retries and other machinery of our workflow state polling. Used only byRootWorkflowClientInvokerand basically encapsulate pieces ofRootWorkflowClientInvoker, so made package-local.WorkflowClientHelpercontains different methods that could but didn't become a part of the mainWorkflowClient, mostly because they shouldn't be a part of normal usage and exist for tests / debug only.This PR improves code quality and maintainability and helps achieve #650
How was this tested:
This PR doesn't change any behaviors, it's just relocation of methods.