Switch SelfAdvancingTimerImplTest to use fixed clock to reduce flakes and improve the quality of checks #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spikhalskiy
requested review from
Sushisource,
mfateev and
vitarb
as code owners
Spikhalskiy
force-pushed
the
issue-726
branch
from
63cdac9 to
3e84833
Compare
Sushisource
approved these changes
Sep 16, 2021
… and improve the quality of checks SelfAdvancingTimerImpl now updates the time before scheduling Issue temporalio#726
Spikhalskiy
force-pushed
the
issue-726
branch
from
3e84833 to
474f2a2
Compare
mfateev
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Switch SelfAdvancingTimerImplTest to use fixed clock to reduce flakes and improve the quality of checks
SelfAdvancingTimerImpl now updates the time before scheduling
Why?
Fixed mocked clock remove test flakes that could happen because of the load.
It also improves the quality of the test, switching to the fixed clock allowed to catch a problem that
SelfAdvancingTimerImpl#schedulecould use an outdated timestamp.Closes #726