Adapt CheckedExceptionWrapper to Throwables that are not Exceptions and Errors #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spikhalskiy
requested review from
Sushisource,
mfateev and
vitarb
as code owners
mfateev
reviewed
Sep 23, 2021
...-sdk/src/test/java/io/temporal/workflow/failure/WorkflowFailureNonStandardThrowableTest.java
Outdated
Show resolved
Hide resolved
mfateev
reviewed
Sep 23, 2021
...-sdk/src/test/java/io/temporal/workflow/failure/WorkflowFailureNonStandardThrowableTest.java
Show resolved
Hide resolved
Spikhalskiy
force-pushed
the
issue-744
branch
from
35802a5 to
c786a3b
Compare
mfateev
approved these changes
Sep 23, 2021
Spikhalskiy
force-pushed
the
issue-744
branch
from
c786a3b to
fd79b85
Compare
Spikhalskiy
force-pushed
the
issue-744
branch
from
fd79b85 to
599dea2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Adapt CheckedExceptionWrapper to Throwables that are not Exceptions and Errors
Why?
If workflow throws a Throwable that is not an exception or error, we get an internal failure instead of graceful processing.
Closes #744
How was this tested:
Unit tests with a custom throwable