Use ReplayAwareScope to don't double report completion on replays, fix STICKY_CACHE_THREAD_FORCED_EVICTION double reporting #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove duplicate STICKY_CACHE_THREAD_FORCED_EVICTION reporting to address temporalio#201
Spikhalskiy
requested review from
Sushisource,
mfateev and
vitarb
as code owners
Spikhalskiy
commented
Oct 5, 2021
| taskFuture = threadPool.submit(task); | ||
| return; | ||
| } catch (RejectedExecutionException e) { | ||
| getWorkflowContext() |
There was a problem hiding this comment.
This reporting will be done inside cache.evictAnyNotInProcessing call down the line.
Sushisource
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Use ReplayAwareScope for metric reporting to address #759
Remove duplicate STICKY_CACHE_THREAD_FORCED_EVICTION reporting to address #201
Closes #759
Closes #201