Fix SimpleSslContextBuilderTest not testing anything by not loading keys correctly #970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spikhalskiy
requested review from
Sushisource,
bergundy,
cretz,
mfateev and
mmcshane
as code owners
bergundy
approved these changes
Jan 12, 2022
Spikhalskiy
force-pushed
the
fix-sslcontextbuilder-test
branch
from
238df5a to
d9ad0b0
Compare
Spikhalskiy
force-pushed
the
fix-sslcontextbuilder-test
branch
from
d9ad0b0 to
61f21c5
Compare
cretz
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Fix SimpleSslContextBuilderTest not testing anything by not loading keys correctly
Add explicit SimpleSslContextBuilder#noKeyOrCertChain for users configuring client side SSL without a private key or cert chain
Why
A bug slipped in the 1.7.0 release because these tests were not working correctly: #968