Improve WorkflowServiceStubsOptions#setRpcTimeout javadoc #973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spikhalskiy
requested review from
Sushisource,
bergundy,
cretz,
mfateev and
mmcshane
as code owners
Spikhalskiy
force-pushed
the
setRpcTimeout-doc
branch
from
a765461 to
6264815
Compare
Sushisource
reviewed
Jan 13, 2022
temporal-serviceclient/src/main/java/io/temporal/serviceclient/WorkflowServiceStubsOptions.java
Outdated
Show resolved
Hide resolved
Spikhalskiy
force-pushed
the
setRpcTimeout-doc
branch
from
c5d1664 to
a1b9880
Compare
cretz
approved these changes
Jan 13, 2022
Provide a note that the total client-server interaction is not limited by rpcTimeout Co-authored-by: Spencer Judge <sjudge@hey.com>
Spikhalskiy
force-pushed
the
setRpcTimeout-doc
branch
from
a1b9880 to
f398a86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a note that the total client-server interaction is not limited by
rpcTimeout