Provide configuration hooks extending usage of standard SDK configuration functionality #984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spikhalskiy
requested review from
Sushisource,
bergundy,
cretz,
mfateev and
mmcshane
as code owners
cretz
approved these changes
Jan 18, 2022
Spikhalskiy
force-pushed
the
channel-configuration-hook
branch
from
734bc6d to
8c16d7b
Compare
…tion functionality
Spikhalskiy
force-pushed
the
channel-configuration-hook
branch
from
8c16d7b to
3f16b63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added
that provide a more flexible approach to configuration.
Why?
Previously users were able to either use basic config functionality of WorkflowServiceStubsOptions OR a fully custom channel. This works fine until users need to tweak or change some exotic parameter of the gRPC channel. To do that they have to fall back to a fully custom channel and stop using the whole Temporal built-in configuration.
Now users can use the full standard Temporal configuration and tune some parameters of the channel right before it gets built using a listener.