Skip to content

Don't fail on newtype string dict keys #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 29, 2025
Merged

Don't fail on newtype string dict keys #1059

merged 3 commits into from
Aug 29, 2025
+28 −1

Conversation

tconley1428
Copy link
Contributor

What was changed

Check for newtype before calling isinstance.

Why?

isinstance fails when the key_type is not a type.

Checklist

  1. Closes part of [Bug] value_to_type fails with custom string types as dictionary keys #1032

  2. How was this tested:
    New tests

  3. Any docs updates needed?

@tconley1428 tconley1428 requested a review from a team as a code owner August 27, 2025 14:40
@tconley1428 tconley1428 mentioned this pull request Aug 27, 2025
Closed
dandavison
dandavison approved these changes Aug 27, 2025
View reviewed changes
Copy link
Contributor

@dandavison dandavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I did not consider the possibility of NewType in #833.

@tconley1428 tconley1428 merged commit bb90aab into main Aug 29, 2025
54 of 64 checks passed
@tconley1428 tconley1428 deleted the value_type_error branch August 29, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandavison dandavison dandavison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tconley1428 @dandavison