Change Logger::Unknown to Logger::UNKNOWN in scoped_logger.rb
#316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe `Logger::Unknown` is undefined.
I tried adding a test for this by following the dev setup guide in the readme but I hit this error when trying to run a rake task:
```
Caused by:
RbSys::CargoMetadataError: Could not infer Rust crate information using `cargo metadata`. Original error was: RuntimeError: exited with non-zero status (pid 25778 exit 101) Things to check: - Check that your ext/*/Cargo.toml at is valid - If you are using a workspace, make sure you are the root Cargo.toml exists - Make sure `cargo` is installed and in your PATHStderr from `cargo metadata` was: (RbSys::CargoMetadataError)
error: failed to load manifest for workspace member `/Users/joseph/projects/sdk-ruby/temporalio/./ext`
referenced by workspace at `/Users/joseph/projects/sdk-ruby/temporalio/Cargo.toml`
Caused by:
failed to load manifest for dependency `temporal-client`
Caused by:
failed to read `/Users/joseph/projects/sdk-ruby/temporalio/ext/sdk-core/client/Cargo.toml`
Caused by:
No such file or directory (os error 2)
```
|
|
cretz
approved these changes
Aug 14, 2025
May need to clone recursively (i.e. with |
|
(CI failures will be fixed with #317) |
Ah, that was it. It's right there in the readme too. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe
Logger::Unknownis undefined.I tried adding a test for this by following the dev setup guide in the readme but I hit this error when trying to run a rake task: