Remove useless disable_file parameter for ClientConfig.load #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THardy98
force-pushed
the
env_config_remove_disable_file
branch
from
f8a1b67 to
d5e8bdf
Compare
cretz
approved these changes
Sep 16, 2025
…K now sets TLS to True if api key provided with no TLS configuration (default TLS config)
THardy98
force-pushed
the
env_config_remove_disable_file
branch
from
7e88985 to
9350020
Compare
|
@cretz may want to check the latest commit given that, though it's small, it was after your approval |
cretz
reviewed
Sep 18, 2025
There was a problem hiding this comment.
Just saw that the sig/ filename for this file doesn't have the underscore like this one does
| # @return [String, nil] Client API key | ||
| # @!attribute [r] tls | ||
| # @return [ClientConfigTLS, nil] TLS configuration | ||
| # @return [Boolean, ClientConfigTLS, nil] TLS configuration |
There was a problem hiding this comment.
Usually this would have to be accompanied by a sig/ file update, but I think it's not failing CI because we don't populate it from Ruby where the static analyzer could catch it (which is fine)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Remove unnecessary
disable_filefromClientConfig.loadWhy?
Unneeded param