Added retry policy to activity info #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Sep 18, 2025
| local?: false, | ||
| priority: Temporalio::Priority.default, | ||
| raw_heartbeat_details: [], | ||
| retry_policy: RetryPolicy.new, |
There was a problem hiding this comment.
In Python/.NET you chose to make this None/null
There was a problem hiding this comment.
I didn't put much thought to it before but I think non-null is better since it will never be null in practice (except for pre-1.28 servers due to a bug). .Net isn't merged yet, I plan on changing it there too. We might want to fix it in Python too.
There was a problem hiding this comment.
👍 I'm ok with that. I think it might be better to be null than inaccurate, but we're inaccurate with other parts like priority, so all good.
cretz
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Feature request: temporalio/features#615
Checklist
Closes [Feature Request] Show retry policy on activity info #248
How was this tested:
Added assertion to
test_infointest/worker_activity_test.rb.