Add version check for delete workflow transfer task #3159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
reviewed
Jul 28, 2022
| version := currentVersion | ||
| if deleteAfterClose { | ||
| // Ignore version check when delete request is from user API | ||
| version = common.EmptyVersion |
There was a problem hiding this comment.
I think this will cause the version check for close execution task to always fail and task being skipped when deleting an open workflow in a global namespace.
There was a problem hiding this comment.
Good catch. I think it don't need special handling for deleteAfterClose case.
There was a problem hiding this comment.
The current implementation do check version when delete open workflow(deleteAfterClose = true). Is this expected? @alexshtin
yux0
force-pushed
the
delete-version-check
branch
from
62dd1cf
to
58a2d88
Compare
alexshtin
approved these changes
Aug 3, 2022
yycptt
pushed a commit
that referenced
this pull request
Aug 12, 2022
* Add version check to delete workflow transfer task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
We want to use the API in Archival to delete workflow data and it requires version.
How did you test it?
Unit test
Potential risks
Is hotfix candidate?