Skip to content

Conversation

rossedfort
Copy link
Contributor

@rossedfort rossedfort commented Jan 26, 2023

What was changed

  • Use @sveltejs/adapter-static for local builds to fix an issue with relative paths in index.html that we not resolved properly when hosted via ui-server

Why?

Attempt to fix an issue reported by customers

Checklist

  1. Closes
    closes UI fails to load when navigating directly to a page more than one directory deep #1081

  2. How was this tested:

  1. Any docs updates needed?

@rossedfort rossedfort requested a review from a team as a code owner January 26, 2023 23:20
@vercel
Copy link

vercel bot commented Jan 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
holocene ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 27, 2023 at 7:17PM (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 27, 2023 at 7:17PM (UTC)

@cypress
Copy link

cypress bot commented Jan 26, 2023

Passing run #1993 ↗︎

0 82 5 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge a45c4c5 into 0cd2f1d...
Project: Temporal UI Commit: f1b33bb40e ℹ️
Status: Passed Duration: 04:33 💡
Started: Jan 27, 2023 8:19 PM Ended: Jan 27, 2023 8:23 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Collaborator

@GiantRobots GiantRobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave build dir and move it to build for both adapters

@rossedfort
Copy link
Contributor Author

I would leave build dir and move it to build for both adapters

This is a good idea for the record, but I can't get it to work right now, so will make this change in a follow up PR.

@rossedfort rossedfort merged commit bd7dc09 into main Jan 27, 2023
@rossedfort rossedfort deleted the v2.10.0-hotfix branch January 27, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI fails to load when navigating directly to a page more than one directory deep
3 participants