fix some small visual bugs with configurable table #1321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
laurakwhit
approved these changes
Apr 20, 2023
| @apply z-10 bg-primary w-0 border-r-[3px] border-primary cursor-col-resize; | ||
| } | ||
| .resizer.no-columns-pinned:not(.batch-actions-enabled) { |
There was a problem hiding this comment.
I would say just hide the resizer when batch actions are enabled too
Suggested change
| .resizer.no-columns-pinned:not(.batch-actions-enabled) { | |
| .resizer.no-columns-pinned{ |
but I think the hover state is maybe a bit of a blocker for now. What do you think?
There was a problem hiding this comment.
Hm yeah I think just leaving the divider/resizer is OK for now, but I agree that it'd be nicer to hide it an fix the hover state in this case.
...ts/workflow/workflows-summary-configurable-table/workflows-summary-configurable-table.svelte
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
fix some small visual bugs with configurable table
Screenshots (if applicable) 📸
before
after
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Run oss locally and visually verify changes
Checklists
N/a
Draft Checklist
Merge Checklist
Issue(s) closed
N/a
Docs
N/a
Any docs updates needed?