Skip to content

fix: clb attachment - disable target diff if using TCP-SSL listener #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2022
Merged

fix: clb attachment - disable target diff if using TCP-SSL listener #1092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tencentcloud/resource_tc_clb_attachment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,8 @@ func resourceTencentCloudClbServerAttachmentRead(d *schema.ResourceData, meta in
}
}
}
} else if *instance.Protocol == CLB_LISTENER_PROTOCOL_TCP || *instance.Protocol == CLB_LISTENER_PROTOCOL_UDP {
// TCP / UDP / TCP_SSL
} else if instance.Targets != nil {
onlineTargets = instance.Targets
}

Expand Down
52 changes: 52 additions & 0 deletions tencentcloud/resource_tc_clb_attachment_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,15 @@ func TestAccTencentCloudClbServerAttachment_tcp(t *testing.T) {
resource.TestCheckResourceAttr("tencentcloud_clb_attachment.foo", "protocol_type", "TCP"),
resource.TestCheckResourceAttr("tencentcloud_clb_attachment.foo", "targets.#", "1"),
),
}, {
Config: testAccClbServerAttachment_tcp_update_ssl,
Check: resource.ComposeTestCheckFunc(
testAccCheckClbServerAttachmentExists("tencentcloud_clb_attachment.foo"),
resource.TestCheckResourceAttrSet("tencentcloud_clb_attachment.foo", "clb_id"),
resource.TestCheckResourceAttrSet("tencentcloud_clb_attachment.foo", "listener_id"),
resource.TestCheckResourceAttr("tencentcloud_clb_attachment.foo", "protocol_type", "TCP_SSL"),
resource.TestCheckResourceAttr("tencentcloud_clb_attachment.foo", "targets.#", "1"),
),
},
},
})
Expand Down Expand Up @@ -154,6 +163,10 @@ func testAccCheckClbServerAttachmentExists(n string) resource.TestCheckFunc {
}

const testAccClbServerAttachment_tcp = instanceCommonTestCase + `
data "tencentcloud_ssl_certificates" "foo" {
name = "keep"
}

resource "tencentcloud_clb_instance" "foo" {
network_type = "OPEN"
clb_name = "tf-clb-attach-tcp-test"
Expand Down Expand Up @@ -187,6 +200,10 @@ resource "tencentcloud_clb_attachment" "foo" {
`

const testAccClbServerAttachment_tcp_update = instanceCommonTestCase + `
data "tencentcloud_ssl_certificates" "foo" {
name = "keep"
}

resource "tencentcloud_clb_instance" "foo" {
network_type = "OPEN"
clb_name = "tf-clb-attach-tcp-test"
Expand Down Expand Up @@ -219,6 +236,41 @@ resource "tencentcloud_clb_attachment" "foo" {
}
`

const testAccClbServerAttachment_tcp_update_ssl = instanceCommonTestCase + `
data "tencentcloud_ssl_certificates" "foo" {
name = "keep"
}

resource "tencentcloud_clb_instance" "foo" {
network_type = "OPEN"
clb_name = "tf-clb-attach-tcp-ssl"
vpc_id = var.cvm_vpc_id
}

# This is will force new as expected
resource "tencentcloud_clb_listener" "foo" {
clb_id = tencentcloud_clb_instance.foo.id
listener_name = "tf-clb-attach-tcp-ssl"
port = 44
protocol = "TCP_SSL"
health_check_switch = true
scheduler = "WRR"
certificate_ssl_mode = "UNIDIRECTIONAL"
certificate_id = data.tencentcloud_ssl_certificates.foo.certificates.0.id
}

resource "tencentcloud_clb_attachment" "foo" {
clb_id = tencentcloud_clb_instance.foo.id
listener_id = tencentcloud_clb_listener.foo.listener_id

targets {
instance_id = tencentcloud_instance.default.id
port = 23
weight = 50
}
}
`

const testAccClbServerAttachment_http = instanceCommonTestCase + `
resource "tencentcloud_clb_instance" "foo" {
network_type = "OPEN"
Expand Down