Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mariadb): [116318703] support ip port #2583

Merged
merged 3 commits into from
Apr 7, 2024
Merged

fix(mariadb): [116318703] support ip port #2583

merged 3 commits into from
Apr 7, 2024

Conversation

gitmkn
Copy link
Collaborator

@gitmkn gitmkn commented Apr 3, 2024

No description provided.

Copy link
Collaborator

@andrew-tx andrew-tx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrew-tx andrew-tx added the run check run check label Apr 3, 2024
"vport": {
Type: schema.TypeInt,
Computed: true,
Description: "Intranet port.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

新增的字段补充下测试用例覆盖

@gitmkn gitmkn added run check run check and removed run check run check labels Apr 7, 2024
@andrew-tx andrew-tx merged commit 68d8223 into master Apr 7, 2024
9 checks passed
@andrew-tx andrew-tx deleted the fix/mariadb-ip branch April 7, 2024 13:34
SevenEarth pushed a commit that referenced this pull request Apr 10, 2024
* fix(mariadb): [116318703] support ip port

* feat: add change log

* fix: modify test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run check run check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants