Skip to content

feat: http rule realservers is optional #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2020
Merged

feat: http rule realservers is optional #476

merged 1 commit into from
Jul 22, 2020

Conversation

Sherlock-Holo
Copy link
Contributor

allow gaap http rule argument realservers be Optional

@Sherlock-Holo
Copy link
Contributor Author 

go test -v -run=TestAccTencentCloudGaapHttpRule -timeout 120m
=== RUN   TestAccTencentCloudGaapHttpRule_basic
--- PASS: TestAccTencentCloudGaapHttpRule_basic (33.59s)
=== RUN   TestAccTencentCloudGaapHttpRule_httpUpdate
--- PASS: TestAccTencentCloudGaapHttpRule_httpUpdate (46.65s)
=== RUN   TestAccTencentCloudGaapHttpRule_httpUpdateRealservers
--- PASS: TestAccTencentCloudGaapHttpRule_httpUpdateRealservers (40.04s)
=== RUN   TestAccTencentCloudGaapHttpRule_noHealth
--- PASS: TestAccTencentCloudGaapHttpRule_noHealth (30.86s)
=== RUN   TestAccTencentCloudGaapHttpRule_domainRealserver
--- PASS: TestAccTencentCloudGaapHttpRule_domainRealserver (36.24s)
=== RUN   TestAccTencentCloudGaapHttpRule_noRealserver
--- PASS: TestAccTencentCloudGaapHttpRule_noRealserver (33.69s)
=== RUN   TestAccTencentCloudGaapHttpRule_deleteRealserver
--- PASS: TestAccTencentCloudGaapHttpRule_deleteRealserver (41.62s)
PASS
ok      github.com/terraform-providers/terraform-provider-tencentcloud/tencentcloud     262.705s

longkai
longkai approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@longkai longkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

@likexian likexian merged commit 913acef into tencentcloudstack:master Jul 22, 2020
@Sherlock-Holo Sherlock-Holo deleted the gaap-rs-optional branch July 23, 2020 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@longkai longkai longkai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sherlock-Holo @longkai @likexian