Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: remove PlanTerminationStatusInvariant #217

Closed
hallazzang opened this issue Nov 8, 2021 · 0 comments · Fixed by #223
Closed

bug: remove PlanTerminationStatusInvariant #217

hallazzang opened this issue Nov 8, 2021 · 0 comments · Fixed by #223
Assignees
@hallazzang
Labels
bug Something isn't working

Comments

@hallazzang
Copy link
Contributor

Since x/crisis module's end-blocker has the highest order amongst other end-blockers, PlanTerminationStatusInvariant can never check if the termination status is broken or not, without using additional states for that purpose.
Thus, we can consider removing PlanTerminationStatusInvariant entirely.
@hallazzang hallazzang added the bug Something isn't working label Nov 8, 2021
@hallazzang hallazzang mentioned this issue Nov 8, 2021
Merged
9 tasks
@hallazzang hallazzang self-assigned this Nov 8, 2021
hallazzang added a commit to hallazzang/farming that referenced this issue Nov 10, 2021
@hallazzang
fix: remove PlanTerminationStatusInvariant
314a1e2 
see tendermint#217 for details
@hallazzang hallazzang mentioned this issue Nov 10, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hallazzang hallazzang

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove PlanTerminationStatusInvariant hallazzang/farming
1 participant
@hallazzang