Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit batch height issue #346

Merged
merged 7 commits into from
May 19, 2021

Conversation

hallazzang
Copy link
Contributor

@hallazzang hallazzang commented May 19, 2021

Description

Modify batch execution logic to run deterministic when params.unitBatchHeight is not 1
Currently, unitBatchHeight counting has been underway since some Batch Msg entered each batch


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #346 (219eb78) into develop (fce1add) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #346      +/-   ##
===========================================
+ Coverage    83.21%   83.26%   +0.05%     
===========================================
  Files           20       20              
  Lines         2240     2247       +7     
===========================================
+ Hits          1864     1871       +7     
  Misses         207      207              
  Partials       169      169              
Impacted Files Coverage Δ
x/liquidity/keeper/batch.go 86.36% <100.00%> (ø)
x/liquidity/keeper/liquidity_pool.go 79.60% <100.00%> (+0.03%) ⬆️
x/liquidity/keeper/swap.go 87.09% <100.00%> (+1.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fce1add...219eb78. Read the comment docs.

@dongsam dongsam marked this pull request as ready for review May 19, 2021 07:20
@dongsam dongsam merged commit 4d17d74 into tendermint:develop May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants