[FEAT] Add tryFetchTx method to RetryTxSender #70
Conversation
harrisluo
requested review from
richardwu,
ilmoi,
avoc-ado and
nftechie
as code owners
| } finally { | ||
| this._stopWaiting(); | ||
| } | ||
| } |
There was a problem hiding this comment.
So this wouldn't have WS right? Did you ever figure out why WS wasn't ever really working with tryConfirm (polling almost always beat it).
There was a problem hiding this comment.
Yup this wouldn't have WS, just polling. Haven't had the chance to look into WS in tryConfirm yet, will do tn.
There was a problem hiding this comment.
After some testing, it looks like WS confirming is reliable. Both WS and polling at 300 ms intervals are roughly equally likely to pick up a confirmed status, and turning the poll interval up from 2000 ms wasn't strictly necessary since WS would have picked it up.
Polling getTransaction at 300ms intervals appears to yield similar results to WS + 300 ms getSignatureStatus poll, with the added benefit of eliminating the additional call to fetch the actual tx. So the getTransaction approach is promising.
The method serves as an alternative to
tryConfirmthat also fetches the transaction from chain. To confirm a tx, exactly one oftryConfirmortryFetchTxshould be called since they mutate the same underlying state controlling async sending triggered bysend.