Backends #39
Merged
Backends #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng to reshape2) for qudit systems.
…y math.floor() to int directly.
refraction-ray
requested changes
Aug 27, 2025
|
|
||
| size = self.sizen(a) | ||
| if size == 0: | ||
| return self.reshape(a, (0,)) |
There was a problem hiding this comment.
what is reshape (0) mean? just return a?
There was a problem hiding this comment.
Typically, a tensor with size=0 can still have multiple shape possibilities, such as shape=(2, 0, 5), (0, ), (0, 3). These three tensors with different shapes all belong to the size=0 case. To ensure consistent output under this API and avoid potential shape errors, we use reshape(a, (0, )).
|
LGTM now, thanks for the contribution |
|
@all-contributors please add @WeiguoMa for code, tests |
|
I've put up a pull request to add @WeiguoMa! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add clip() and floor() functions for backends. Add reshaped() function to abstractbackend as a preparation for qudit systems. Add corresponding tests in tests/test_backends.py for clip() and floor().