Fix bug in "xy" mode for bilinear interpolation

[djl11]

Fixed incorrect clipping of query indices for non-square images.
Also modified tests to use non-square images.

Additional note: a single tf.reverse(query_points, -1) operation in an if statement could simplify this function for "ij" vs "xy" mode.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[djl11]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[seanpmorgan]

For non-square images, the current code creates out-of-bounds pixel queries during the tf.gather operation. This changes fixes this.

Additional note: using non-square images in unit tests would prevent these kinds of errors.

Also: a single tf.reverse(query_points, -1) operation in an if statement could simplify this function for "ij" vs "xy" mode.

Thanks @djl11! Could you please add a test case as you describe.

[seanpmorgan]

LGTM thanks! There's a lint error that I'm going to fix so we can get this into the 0.7 release.

[googlebot]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[djl11]

@googlebot I consent.

[seanpmorgan]

@googlebot I consent.

@djl11 don't worry about the CLA I'll override it. In the future to fix the lint errors just run:
bash tools/run_docker.sh -c 'make code-format'

Sorry I would have just asked you if I had known you're online. I'm planning to cut 0.7 right after these tests and merge. You'll be credited with the commit just FYI

[djl11]

@seanpmorgan okay great, wasn't sure about the lint errors, thanks for the advice!
I'll leave it to you for now then. Cheers!

[seanpmorgan]

LGTM thanks the fix! Welcome to addons!