Skip to content

Remove py 3.5 from docs and testing. #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2020
Merged

Remove py 3.5 from docs and testing. #256

merged 2 commits into from
Nov 25, 2020

Conversation

pavithrasv
Copy link
Member

No description provided.

@google-cla google-cla bot added the cla: yes label Nov 24, 2020
@SinaChavoshi
Copy link
Collaborator

SinaChavoshi commented Nov 25, 2020 •
edited
Loading

\lgtm

@ucdmkt
Copy link
Contributor

ucdmkt commented Nov 25, 2020

Do you need to mark this as a part of release note, since this is backward-incompatible change?

Since this change isn't because of code change in this library per se, another option would have been to cap upperbound of dependency on Keras/TF. Having that said, since Py3.5 EOL is already past, I think either approach is fine.

@pavithrasv
Copy link
Member Author

Do you need to mark this as a part of release note, since this is backward-incompatible change?

Since this change isn't because of code change in this library per se, another option would have been to cap upperbound of dependency on Keras/TF. Having that said, since Py3.5 EOL is already past, I think either approach is fine.

Added to release notes.

ucdmkt
ucdmkt approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@ucdmkt ucdmkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\lgtm

@SinaChavoshi
Copy link
Collaborator

\lgtm

@pavithrasv pavithrasv added ready to pull PR ready for merge process kokoro:run labels Nov 25, 2020
@copybara-service copybara-service bot merged commit b739982 into tensorflow:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SinaChavoshi SinaChavoshi SinaChavoshi approved these changes

@fchollet fchollet Awaiting requested review from fchollet

+1 more reviewer

@ucdmkt ucdmkt ucdmkt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes ready to pull PR ready for merge process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pavithrasv @SinaChavoshi @ucdmkt @tf-cloud-robot