Skip to content

Conversation

nuka137
Copy link
Contributor

@nuka137 nuka137 commented Nov 20, 2019

This pull request adds the document about the graph optimization performing internally in TensorFlow.
This document shows what optimizations are performed in TensorFlow, and how to enable/disable these optimizations from Python API.
I think most of TensorFlow beginners does not interests, but this document helps the advanced user who wants to control the graph optimizations manually.

This pull request is related to #511 .
#511 targets to TensorFlow 1.x, so I rewrote whole documents for TensorFlow 2.0.

@tfdocsbot
Copy link
Collaborator

Preview and run these notebook edits with Google Colab:

Notebook diffs available on ReviewNB.com.

@googlebot googlebot added the cla: yes CLA has been signed label Nov 20, 2019
@nuka137
Copy link
Contributor Author

nuka137 commented Nov 24, 2019

@lamberta

I rewrote the document in #511 which is rejected due to the transition phase of the TensorFlow 1.x -> 2.x.
Is this document still acceptable in TensorFlow 2.0?

This pull request adds the new .ipynb file because there is no related documents about the graph optimization in the current documents.
Should I merge this document to another file?

@lamberta
Copy link
Member

Thanks, @nuka137 !

Colab preview: https://colab.research.google.com/github/nuka137/docs/blob/graph_optimization/site/en/guide/graph_optimization.ipynb

The challenge will be finding reviewers (and it's a holiday week in the US). Looping in @mdanatg and @alextp to take a quick look. Either as a standalone user guide on tensorflow.org, or in an API reference section.

Also, for notebooks, make sure the format matches the TF notebook template.

@mdanatg
Copy link

mdanatg commented Nov 25, 2019 via email

@nuka137
Copy link
Contributor Author

nuka137 commented Nov 26, 2019

@lamberta @mdanatg @alextp

Thanks for your instructions!
I fixed the graph_optimization.ipynb to match the TF notebook template, and move to site/en/tutorials/customization/graph_optimization.ipynb from site/en/guide/graph_optimization.ipynb.
So, new link for Colab is now located at site/en/tutorials/customization/graph_optimization.

Could you review it again?

"cell_type": "markdown",
"metadata": {},
"source": [
"* Disable All Graph Optimizations\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not getting rendered right, I think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I fixed to use h3 for emphasizing.

@lamberta
Copy link
Member

Thanks @nuka137 for the updates, and @alextp for the review.

@anirudh161 if you have some time, can you take an editorial pass through this community guide and get it ready to publish on tensorflow.org?

@lamberta
Copy link
Member

Staging link: https://colab.research.google.com/github/nuka137/docs/blob/graph_optimization/site/en/guide/_graph_optimization.ipynb

Thanks, all. Bringing this PR in so @anirudh161 can work on it before publishing

@lamberta lamberta added the ready to pull Start merge process label Dec 11, 2019
@lamberta lamberta added ready to pull Start merge process and removed ready to pull Start merge process labels Dec 11, 2019
TensorFlow-Docs-Copybara pushed a commit that referenced this pull request Dec 12, 2019
@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit dd06731 into tensorflow:master Dec 12, 2019
@nuka137 nuka137 deleted the graph_optimization branch March 15, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-editorial-review cla: yes CLA has been signed lgtm Community-added approval ready to pull Start merge process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants