-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Add Document about the Graph Optimization in TensorFlow #1206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Document about the Graph Optimization in TensorFlow #1206
Conversation
Preview and run these notebook edits with Google Colab: Notebook diffs available on ReviewNB.com. |
I rewrote the document in #511 which is rejected due to the transition phase of the TensorFlow 1.x -> 2.x. This pull request adds the new |
Thanks, @nuka137 ! Colab preview: https://colab.research.google.com/github/nuka137/docs/blob/graph_optimization/site/en/guide/graph_optimization.ipynb The challenge will be finding reviewers (and it's a holiday week in the US). Looping in @mdanatg and @alextp to take a quick look. Either as a standalone user guide on tensorflow.org, or in an API reference section. Also, for notebooks, make sure the format matches the TF notebook template. |
Nice! I gave it a quick look and I think it would make a great guide,
heping to demystify what happens under the hood. Happy to review the PR
when ready.
For location, I think Tutorials/Advanced/Customization is a good place - it
seems closely related to "Performance with tf.function" that also sits in
there.
Cheers,
Dan
…On Mon, Nov 25, 2019 at 1:12 PM Billy Lamberta ***@***.***> wrote:
Thanks, @nuka137 <https://github.com/nuka137> !
Colab preview:
https://colab.research.google.com/github/nuka137/docs/blob/graph_optimization/site/en/guide/graph_optimization.ipynb
The challenge will be finding reviewers (and it's a holiday week in the
US). Looping in @mdanatg <https://github.com/mdanatg> and @alextp
<https://github.com/alextp> to take a quick look. Either as a standalone
user guide on tensorflow.org, or in an API reference section.
Also, for notebooks, make sure the format matches the TF notebook template
<https://github.com/tensorflow/docs/blob/master/tools/templates/notebook.ipynb>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1206?email_source=notifications&email_token=AGLFDQ4EUGIRQAZHYEIPDWDQVQIQHA5CNFSM4JPMB7FKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFDJVXA#issuecomment-558275292>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGLFDQ5QMN6U6R7V4KIX4YTQVQIQHANCNFSM4JPMB7FA>
.
|
Thanks for your instructions! Could you review it again? |
"cell_type": "markdown", | ||
"metadata": {}, | ||
"source": [ | ||
"* Disable All Graph Optimizations\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not getting rendered right, I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I fixed to use h3 for emphasizing.
Thanks @nuka137 for the updates, and @alextp for the review. @anirudh161 if you have some time, can you take an editorial pass through this community guide and get it ready to publish on tensorflow.org? |
Staging link: https://colab.research.google.com/github/nuka137/docs/blob/graph_optimization/site/en/guide/_graph_optimization.ipynb Thanks, all. Bringing this PR in so @anirudh161 can work on it before publishing |
PiperOrigin-RevId: 285212209
This pull request adds the document about the graph optimization performing internally in TensorFlow.
This document shows what optimizations are performed in TensorFlow, and how to enable/disable these optimizations from Python API.
I think most of TensorFlow beginners does not interests, but this document helps the advanced user who wants to control the graph optimizations manually.
This pull request is related to #511 .
#511 targets to TensorFlow 1.x, so I rewrote whole documents for TensorFlow 2.0.