Skip to content

fix link on contribute/docs page #1587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 2, 2020
Merged

fix link on contribute/docs page #1587

merged 3 commits into from
Jun 2, 2020

Conversation

Molkree
Copy link
Contributor

@Molkree Molkree commented May 30, 2020

3 whitespaces were added after https:// in this commit d18c835#diff-89f8d80a3fb313d1d00abbc99eb5c180
also extra typo at the bottom

@Molkree Molkree requested review from ewilderj and lamberta as code owners May 30, 2020 17:31
@googlebot googlebot added the cla: yes CLA has been signed label May 30, 2020
shivaylamba
shivaylamba previously approved these changes May 30, 2020
View reviewed changes
@tfdocsbot tfdocsbot added the lgtm Community-added approval label May 30, 2020
lamberta
lamberta previously approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@lamberta lamberta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lamberta lamberta added the ready to pull Start merge process label Jun 1, 2020
@lamberta
Copy link
Member

lamberta commented Jun 1, 2020

cc: @MarkDaoust ---in case this commit indicates a problem with the automation

@MarkDaoust
Copy link
Member

I'm not sure what's up with the whitespace, but the "g" may be to hide github path from the import script.

@lamberta lamberta removed the ready to pull Start merge process label Jun 1, 2020
@Molkree
Copy link
Contributor Author

Molkree commented Jun 1, 2020

Should I return "g" as a g symbol?

@lamberta
Copy link
Member

lamberta commented Jun 1, 2020

Should I return "g" as a g symbol?

Yeah, thanks. Maybe add an html comment after the paragraph to avoid confusion later:
<!-- github.com path intentionally formatted to hide from import script. -->

@Molkree
Reverted "g" symbol as &#103;
a7f6711 
To hide github.com from import script
@Molkree Molkree dismissed stale reviews from lamberta and shivaylamba via a7f6711 June 1, 2020 20:45
@Molkree
Copy link
Contributor Author

Molkree commented Jun 1, 2020

Oh, it probably was a mistake to include symbol code in the commit message, GitHub thought I'm linking PR.
P.S. And it's funny how it properly shows &#103; in the message here but converts it to just "g" letter in quoted text.

@Molkree Molkree requested a review from lamberta June 1, 2020 20:52
lamberta
lamberta approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@lamberta lamberta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lamberta lamberta added the ready to pull Start merge process label Jun 1, 2020
@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit f532605 into tensorflow:master Jun 2, 2020
@Molkree Molkree deleted the Molkree-patch-2 branch June 2, 2020 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lamberta lamberta lamberta approved these changes

@ewilderj ewilderj Awaiting requested review from ewilderj

+1 more reviewer

@shivaylamba shivaylamba shivaylamba left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes CLA has been signed lgtm Community-added approval ready to pull Start merge process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Molkree @lamberta @MarkDaoust @shivaylamba @googlebot @TensorFlow-Docs-Copybara @tfdocsbot