Skip to content

Conversation

rmothukuru
Copy link
Contributor

Fixes 24342

Added the Note, as suggested by Mark in this Github Comment.

Added the Note, as suggested in by Mark in the comment, tensorflow/tensorflow#24342 (comment)
@google-cla google-cla bot added the cla: yes CLA has been signed label Jun 15, 2021
@github-actions
Copy link

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs

$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb
$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin patch-1

MarkDaoust
MarkDaoust previously approved these changes Jun 15, 2021
@MarkDaoust MarkDaoust added the ready to pull Start merge process label Jun 15, 2021
@github-actions github-actions bot added the lgtm Community-added approval label Jun 15, 2021
@google-cla
Copy link

google-cla bot commented Jun 15, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no CLA has not been signed and removed cla: yes CLA has been signed labels Jun 15, 2021
Copy link
Contributor

@8bitmp3 8bitmp3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the notebook:

-         "...feature normalization, normalization makes training much more stable. "
+         "...feature normalization, normalization makes training much more stable.\n",

(This can happen when adding new lines in the same notebook cell while working with a raw JSON file).

LGTM.

@8bitmp3 8bitmp3 added cla: yes CLA has been signed and removed cla: no CLA has not been signed labels Jun 15, 2021
@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit 1cbc25b into tensorflow:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA has been signed lgtm Community-added approval ready to pull Start merge process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Predict fuel efficiency: regression example should not normalize one-hot values
4 participants