Skip to content

Conversation

agentydragon
Copy link
Contributor

Currently "log pi_theta" is rendered as if "log" was a multiplication of l * o * g:
image

@google-cla google-cla bot added the cla: yes CLA has been signed label Sep 8, 2021
@github-actions
Copy link

github-actions bot commented Sep 8, 2021

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs

$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb
$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin patch-1

@8bitmp3 8bitmp3 self-assigned this Sep 8, 2021
@8bitmp3 8bitmp3 added the review in progress Someone is actively reviewing this PR label Sep 8, 2021
Copy link
Contributor

@8bitmp3 8bitmp3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @agentydragon

In Markdown, this would be:

$$L_{actor} = -\sum^{T}_{t=1} \log\pi_{\theta}(a_{t} | s_{t})[G(s_{t}, a_{t})  - V^{\pi}_{\theta}(s_{t})]$$

which should render as:

image

LGTM

@github-actions github-actions bot added the lgtm Community-added approval label Oct 14, 2021
@8bitmp3 8bitmp3 added ready to pull Start merge process and removed review in progress Someone is actively reviewing this PR labels Oct 14, 2021
@8bitmp3
Copy link
Contributor

8bitmp3 commented Oct 14, 2021

The notation remains similar to steps 3-4 on slide 13 http://rail.eecs.berkeley.edu/deeprlcourse-fa17/f17docs/lecture_5_actor_critic_pdf

image

@copybara-service copybara-service bot merged commit 6eb1e08 into tensorflow:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA has been signed lgtm Community-added approval ready to pull Start merge process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants