Skip to content

Conversation

RenuPatelGoogle
Copy link
Contributor

updated 'preprocessing.TextVectorization' with 'tf.keras.layers.TextVectorization' in Prepare the dataset for training section.

updated 'preprocessing.TextVectorization' with 'tf.keras.layers.TextVectorization' in Prepare the dataset for training section.
@google-cla google-cla bot added the cla: yes CLA has been signed label Oct 20, 2021
@github-actions
Copy link

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs

$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb
$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin patch-5

Copy link
Member

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here could you also remove the references to tf.keras.preprocessing?

  • the from tensorflow.keras import preprocessing
  • preprocessing.text_dataset_from_directory should be tf.keras.utils.text_dataset_from_directory

Thanks.

Removed 'from tensorflow.keras import preprocessing'
Changed 'tf.keras.preprocessing.text_dataset_from_directory' with 'tf.keras.utils.text_dataset_from_directory'  at 3 places (raw_train_ds, raw_val_ds and raw_test_ds) in Download and explore the dataset section.
Changed 'preprocessing.TextVectorization' with 'tf.keras.layers.TextVectorization' at Load the dataset section
@RenuPatelGoogle
Copy link
Contributor Author

While you're here could you also remove the references to tf.keras.preprocessing?

  • the from tensorflow.keras import preprocessing
  • preprocessing.text_dataset_from_directory should be tf.keras.utils.text_dataset_from_directory

Thanks.

Updated the same as you referred. Could you please review the document again?

MarkDaoust
MarkDaoust previously approved these changes Nov 2, 2021
@MarkDaoust MarkDaoust added the ready to pull Start merge process label Nov 2, 2021
@github-actions github-actions bot added the lgtm Community-added approval label Nov 2, 2021
@MarkDaoust MarkDaoust added ready to pull Start merge process and removed ready to pull Start merge process labels Nov 2, 2021
@8bitmp3
Copy link
Contributor

8bitmp3 commented Nov 4, 2021

Let me look into the CI / Notebook lint test for you @RenuPatelGoogle Thanks for the PR!

@8bitmp3 8bitmp3 self-assigned this Nov 4, 2021
@8bitmp3 8bitmp3 removed the ready to pull Start merge process label Nov 4, 2021
8bitmp3
8bitmp3 previously approved these changes Nov 4, 2021
@8bitmp3 8bitmp3 added the ready to pull Start merge process label Nov 4, 2021
@copybara-service copybara-service bot merged commit bbeb31a into tensorflow:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA has been signed lgtm Community-added approval ready to pull Start merge process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants