Skip to content

Conversation

danielsparing
Copy link
Contributor

Without expanding dimensions, multi-hot encoded columns are not correctly illustrated (they will be parsed as single-record multi-label, not single-label multi-record).

(Another question is whether we need multi-hot for these columns instead of one-hot, as they are not multi-label?)

Without expanding dimensions, multi-hot encoded columns are not correctly illustrated (they will be parsed as single-record multi-label, not single-label multi-record).

(Another question is whether we need multi-hot for these columns instead of one-hot, as they are not multi-label?)
@google-cla google-cla bot added the cla: yes CLA has been signed label Nov 4, 2021
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs

$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb
$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin patch-1

@MarkDaoust
Copy link
Member

Thanks.

@github-actions github-actions bot added the lgtm Community-added approval label Nov 4, 2021
@8bitmp3 8bitmp3 self-assigned this Nov 4, 2021
@8bitmp3
Copy link
Contributor

8bitmp3 commented Nov 4, 2021

Thank you @danielsparing and @MarkDaoust. Really appreciate it. I'll review the doc to make sure it passes the CI / Notebook lint test 👍

@8bitmp3
Copy link
Contributor

8bitmp3 commented Nov 4, 2021

The notebook uses Keras-native and the CI test is checking for words found in the inclusive wordlist. LGTM!

@8bitmp3 8bitmp3 added the ready to pull Start merge process label Nov 4, 2021
@copybara-service copybara-service bot merged commit 9c485ed into tensorflow:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA has been signed lgtm Community-added approval ready to pull Start merge process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants