Change manifest to include anything under */templates/*.
#1991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not 100% what's going on, but I think the `recursive-include` statements are somehow bound to unixy paths, as they weren't being included in the built package on Windows. Should address [this issue](tensorflow/tensorflow#53216).
MarkDaoust
reviewed
Jan 6, 2022
MANIFEST.in
Outdated
| global-include **/templates/* |
There was a problem hiding this comment.
What happened to the gen_java files?
There was a problem hiding this comment.
They're gen_java/templates, so they're covered by this.
There was a problem hiding this comment.
Ah, I see what you mean, the shell script in gen_java wouldn't be covered by this, nor the python includes. I'll double check that now.
There was a problem hiding this comment.
Fixed now. I've included *.sh across the repo & confirmed it's only added the one file. I think that's fine, under the assumption that we want our shell scripts packaged too.
PTAL
MarkDaoust
previously approved these changes
Jan 6, 2022
MarkDaoust
previously approved these changes
Jan 6, 2022
|
Merge conflict. PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure what's going on, but I think the
recursive-includestatements are somehow bound to unixy paths, as they weren't being included in the built package on Windows.Should address this issue.