-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Update word2vec.ipynb #2000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update word2vec.ipynb #2000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you keep the original URL:
https://tensorflow.org/tutorials/text/images/word2vec_negative_sampling.png
And replace the old image at images/word2vec_negative_sampling.png
Also please be sure you're using an actual PNG file, not a JPEG. JPEG is not a good format for diagrams.
Made the necessary changes as told by you. However, the old file on the link is visible in the notebook, not the new file, I guess this is because my image is not hosted on the TensorFlow website. |
Thanks. It doesn't show up yet, but after submission this will eventually get synced to tensorflow.org, and then the changes will be visible in the doc. I could have been more clear about that. |
@MarkDaoust I have already done the changes as told by you. Do I need to make any more changes as I can see some changes are requested in the PR. |
I think Everything's okay here. Let me see if I can merge it. |
Thanks @Yashashree304 @MarkDaoust On it (import/copybara) |
@Yashashree304 There may be some issues with the grammar/syntax here: Since the input [Updated]
(Notice the back ticks.) [Update] Also, as per @markmcd 's suggestion, let's place the text outside the image so that it's more accessible and easier to maintain.
LMKWYT |
That is an improvement, thanks @8bitmp3. |
Fixes tensorflow/tensorflow#50104