-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Simplify GPU install instructions. #2055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Now that TensorRT is available in the regular CUDA apt repos, the 'machine-learning' repos are no longer needed in the GPU setup instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating these to use cuda-keyring
package to enable the CUDA repository.
Thanks @nluehr ! @mihaimaruseac @MarkDaoust PTAL, thanks! |
|
||
# Install TensorRT. Requires that libcudnn8 is installed above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to remove the TensorRT installation instructions? Have they changed?
The PR description only notes that TensorRT is available elsewhere, I assume it still needs to be installed?
If this section does need to be removed, then the "software requirements" section will need to be updated to remove the "install tensorrt" entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mihaimaruseac Can you also please check the TensorRT section ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TensorRT installation has been combined with the rest of the CUDA installation (see the libnvinfer* packages) since all packages are now available from a common apt repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that info - please update the "software requirements" section to remove the "install tensorrt" entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead I added a comment noting that libnvinfer optional and needed for TensorRT.
PTAL.
@8bitmp3 I've taken a look but it looks like I'm not an owner here so can't actually approve, sorry! |
Now that TensorRT is available in the regular CUDA apt repos, the
'machine-learning' repos are no longer needed in the GPU setup instructions.