Skip to content

Conversation

harshdhamecha
Copy link
Contributor

Added time unit (i.e. seconds) in timeit.timeit() in intro_to_graph to make it easily understand by users.

@google-cla
Copy link

google-cla bot commented Sep 30, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

8bitmp3
8bitmp3 previously approved these changes Oct 3, 2022
Copy link
Contributor

@8bitmp3 8bitmp3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. WDYT @MarkDaoust @markmcd

Notebook formatting should be applied automatically later to remove vscode metadata.

@github-actions github-actions bot added the lgtm Community-added approval label Oct 3, 2022
@8bitmp3 8bitmp3 added the ready to pull Start merge process label Oct 3, 2022
@8bitmp3
Copy link
Contributor

8bitmp3 commented Oct 3, 2022

@harshdhamecha Since the bot isn't applied formatting automatically, here's what the CI error message says :

Format notebook: site/en/guide/intro_to_graphs.ipynb

[test] The following notebooks are not formatted:
- site/en/guide/intro_to_graphs.ipynb
Please install `nbfmt` and format:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs
$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb

So, if you can:

$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs
$ python3 -m tensorflow_docs.tools.nbfmt intro_to_graph.ipynb

which should remove some vscode and other metadata.

@copybara-service copybara-service bot merged commit 7252502 into tensorflow:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Community-added approval ready to pull Start merge process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants